Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding CMaize to CMAKE_MODULE_PATH #103

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Fix adding CMaize to CMAKE_MODULE_PATH #103

merged 1 commit into from
Aug 18, 2024

Conversation

zachcran
Copy link
Contributor

Is this pull request associated with an issue(s)?
No, I just noticed this problem while I was looking to fix another issue.

Description
The get_cmaize() function is adding the wrong source directory to CMAKE_MODULE_PATH. After fetching CMaize, it should add cmaize_SOURCE_DIR/cmake to CMAKE_MODULE_PATH but it instead adds cmake_test_SOURCE_DIR/cmake.

@zachcran zachcran added the bump:patch Increments the patch version. label Aug 17, 2024
@zachcran zachcran self-assigned this Aug 17, 2024
Copy link
Contributor

@AutonomicPerfectionist AutonomicPerfectionist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised it worked at all for this long with the wrong include path. Looks good!

@zachcran zachcran merged commit 44dc638 into master Aug 18, 2024
7 checks passed
@zachcran zachcran deleted the get_cmaize_fix branch August 18, 2024 00:07
Copy link

🚀 [bumpr] Bumped! New version:v0.1.16 Changes:v0.1.15...v0.1.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:patch Increments the patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants